Upload artifacts with build suffix#29062
Merged
Merged
Conversation
ashley-cui
force-pushed
the
nightly-names
branch
from
4f7d4e7 to
b02d65b
Compare
The nightly release validation builds both on main and the latest release branch, we should upload the artifacts with a suffix to differentiate the two Signed-off-by: Ashley Cui <acui@redhat.com>
ashley-cui
force-pushed
the
nightly-names
branch
from
b02d65b to
f69796b
Compare
Luap99
approved these changes
Jun 29, 2026
Luap99
left a comment
Luap99
left a comment
Member
There was a problem hiding this comment.
LGTM, I guess we should get this in for now.
But we still should update the DOWNLAODS.md and I guess the one mac artifact name
| uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1 | ||
| with: | ||
| name: mac-installers | ||
| name: mac-installers-${{ needs.get-version.outputs.version_display }} |
Member
There was a problem hiding this comment.
non blocking but we only ship one mac installer now, so I guess this should be singular
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The nightly release validation builds both on main and the latest release branch, we should upload the artifacts with a suffix to differentiate the two
Fixes: #29059
Checklist
Ensure you have completed the following checklist for your pull request to be reviewed:
commits. (
git commit -s). (If needed, usegit commit -s --amend). The author email must matchthe sign-off email address. See CONTRIBUTING.md
for more information.
Fixes: #00000in commit message (if applicable)make validatepr(format/lint checks)Noneif no user-facing changes)Does this PR introduce a user-facing change?